UIORGS-398: modify summary display in organization view mode #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usavkov-epam
approved these changes
Oct 17, 2023
zburke
approved these changes
Oct 17, 2023
Comment on lines
336
to
350
| Boolean(organization.isVendor && organization.isDonor) && ( | ||
| <Accordion | ||
| id={donorContacts} | ||
| label={ORGANIZATION_SECTION_LABELS[donorContacts]} | ||
| > | ||
| {/* | ||
| TODO: add donor contacts list component https://issues.folio.org/browse/UIORGS-394 | ||
| */} | ||
| </Accordion> |
There was a problem hiding this comment.
Boolean(foo && bar)seems superfluous to me sincefoo && barwill already evaluate tobooleanbut 🤷- I am not a fan of placeholder stories that insert a broken/empty UI element. Essentially, they add a bug ("accordion is present but has no content"). I guess that's an issue to take up with your PO, but I would strongly prefer UIORGS-398 to be merged after UIORGS-394 was complete.
There was a problem hiding this comment.
Sure. Thank you for your comments.
alisher-epam
force-pushed
the
UIORGS-398
branch
from
7bbe67c to
36f3c02
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UIORGS-398 - modify summary display in organization view mode
Approach
Screen.Recording.2023-10-17.at.2.02.46.PM.mov
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.